Summary: | [WebKit2] Fix build error in WebKit2/WebProcess module | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shivakumar J M <shiva.jm> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin, gyuyoung.kim, ossy, ryuan.choi, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 136631 | ||||||||
Attachments: |
|
Description
Shivakumar J M
2014-09-08 22:31:06 PDT
Created attachment 237841 [details]
Patch
Fix the build error by handling default case.
Comment on attachment 237841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237841&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:116 > + default: > + return 0_ms; We don’t want a default here, because that will disable the warning that clang and other compilers give us when we forget to handle a case. Instead, we should put this return statement outside the switch, and we should also include ASSERT_NOT_REACHED. Created attachment 237842 [details]
Patch for landing
Comment on attachment 237842 [details]
Patch for landing
cq=me
Comment on attachment 237842 [details] Patch for landing Clearing flags on attachment: 237842 Committed r173420: <http://trac.webkit.org/changeset/173420> All reviewed patches have been landed. Closing bug. |