Bug 136620

Summary:

[SVG] Experiment: Disable SVG animated DOM properties

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

ap, bfulgham, buildbot, cdumez, clopez, cmarcelo, commit-queue, dbates, dino, d-r, esprehn+autocc, fmalita, gyuyoung.kim, kangil.han, kondapallykalyan, nikos.andronikos, pdr, rakuco, rniwa, ryuan.choi, sabouhallawa, sam, schenney, sergio, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Patch	none

Dirk Schulze

Reported 2014-09-08 01:17:37 PDT

We want to explore if it is worth maintaining SVG DOM. Can we remove SVG DOM is there something that we need to keep around? If the experiment completely fails, we unroll the changes and know how the SVG WG should proceed with SVG2.

Attachments
Patch (110.32 KB, patch) 2014-09-08 01:55 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Patch (109.84 KB, patch) 2014-09-08 02:21 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (573.08 KB, application/zip) 2014-09-08 05:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (573.92 KB, application/zip) 2014-09-08 06:22 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (575.88 KB, application/zip) 2014-09-08 07:30 PDT, Build Bot	no flags	Details
Patch (109.99 KB, patch) 2014-09-08 08:11 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2014-09-08 01:55:10 PDT

Created attachment 237767 [details] Patch

Dirk Schulze

Comment 2 2014-09-08 02:21:54 PDT

Created attachment 237769 [details] Patch

Build Bot

Comment 3 2014-09-08 05:28:49 PDT

Comment on attachment 237769 [details] Patch Attachment 237769 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5437169531355136 New failing tests: http/tests/misc/acid3.html http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg

Build Bot

Comment 4 2014-09-08 05:28:55 PDT

Created attachment 237779 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-09-08 06:22:29 PDT

Comment on attachment 237769 [details] Patch Attachment 237769 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4660079487877120 New failing tests: http/tests/misc/acid3.html http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg

Build Bot

Comment 6 2014-09-08 06:22:38 PDT

Created attachment 237780 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-09-08 07:29:53 PDT

Comment on attachment 237769 [details] Patch Attachment 237769 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6549517742637056 New failing tests: http/tests/misc/acid3.html http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg

Build Bot

Comment 8 2014-09-08 07:30:03 PDT

Created attachment 237785 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Dirk Schulze

Comment 9 2014-09-08 08:11:43 PDT

Created attachment 237788 [details] Patch

Dirk Schulze

Comment 10 2014-09-08 08:54:32 PDT

(In reply to comment #9) > Created an attachment (id=237788) [details] > Patch ACID3 will be broken since it checks for SVGRectElement support by asserting rect.width, which this patch removes. A bad check anyway IMO but probably reasonable at the time.

Alexey Proskuryakov

Comment 11 2014-09-08 23:35:37 PDT

This sounds like something that many people on webkit-dev would love to be notified about. Could you please send an e-mail?

Sam Weinig

Comment 12 2014-09-09 16:51:06 PDT

(In reply to comment #0) > We want to explore if it is worth maintaining SVG DOM. Can we remove SVG DOM is there something that we need to keep around? If the experiment completely fails, we unroll the changes and know how the SVG WG should proceed with SVG2. Who is the we here? What data do you plan on collecting to confirm/reject your hypothesis?

Michael Catanzaro

Comment 13 2016-09-17 07:07:56 PDT

Comment on attachment 237788 [details] Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.

Note You need to log in before you can comment on or make changes to this bug.