Bug 136609

Summary: Introduce toBasicShapeFoo() instead of static_cast<BasicShapeFoo*>
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 136773    
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2014-09-07 04:22:47 PDT
To use BasicShapeFoo() helps to detect wrong type casting and improve code readability.
Attachments
Patch (11.53 KB, patch)
2014-09-07 04:23 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-09-07 04:23:56 PDT
Created attachment 237753 [details] Patch
Darin Adler
Comment 2 2014-09-07 11:37:52 PDT
Comment on attachment 237753 [details] Patch Lets try again.
Gyuyoung Kim
Comment 3 2014-09-07 18:01:29 PDT
(In reply to comment #2) > (From update of attachment 237753 [details]) > Lets try again. I will watch debug bot after landing this patch.
WebKit Commit Bot
Comment 4 2014-09-07 18:36:17 PDT
Comment on attachment 237753 [details] Patch Clearing flags on attachment: 237753 Committed r173369: <http://trac.webkit.org/changeset/173369>
WebKit Commit Bot
Comment 5 2014-09-07 18:36:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.