Bug 136609

Summary:

Introduce toBasicShapeFoo() instead of static_cast<BasicShapeFoo*>

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Gyuyoung Kim 2014-09-07 04:22:47 PDT

To use BasicShapeFoo() helps to detect wrong type casting and improve code readability.

Comment 1 Gyuyoung Kim 2014-09-07 04:23:56 PDT

Created attachment 237753 [details]
Patch

Comment 2 Darin Adler 2014-09-07 11:37:52 PDT

Comment on attachment 237753 [details]
Patch

Lets try again.

Comment 3 Gyuyoung Kim 2014-09-07 18:01:29 PDT

(In reply to comment #2)
> (From update of attachment 237753 [details])
> Lets try again.

I will watch debug bot after landing this patch.

Comment 4 WebKit Commit Bot 2014-09-07 18:36:17 PDT

Comment on attachment 237753 [details]
Patch

Clearing flags on attachment: 237753

Committed r173369: <http://trac.webkit.org/changeset/173369>

Comment 5 WebKit Commit Bot 2014-09-07 18:36:22 PDT

All reviewed patches have been landed.  Closing bug.