Bug 136598

Summary: [WinCairo][Curl] fileExists() incorrectly claims folder does not exist.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, bfulgham, commit-queue, galpeter
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

peavo
Reported 2014-09-06 04:22:10 PDT
When the fileExists() function is called in CurlCacheManager::setCacheDirectory() with a folder name ending with a slash or backslash, it will always return false, even if the folder exists. See the documentation of FindFirstFile (http://msdn.microsoft.com/en-us/library/windows/desktop/aa364418(v=vs.85).aspx), where it's stated that it will fail if the file name ends with a backslash.
Attachments
Patch (1.58 KB, patch)
2014-09-06 04:26 PDT, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2014-09-06 04:26:37 PDT
Created attachment 237733 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-06 10:03:03 PDT
Comment on attachment 237733 [details] Patch Clearing flags on attachment: 237733 Committed r173358: <http://trac.webkit.org/changeset/173358>
WebKit Commit Bot
Comment 3 2014-09-06 10:03:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.