Bug 136587

Summary:

Make Dashboard metrics time calculation work with out of order builds

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Description Alexey Proskuryakov 2014-09-05 15:46:10 PDT

We have multiple bots on some queues, so results can come out of order.

Comment 1 Alexey Proskuryakov 2014-09-05 15:51:05 PDT

Created attachment 237716 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2014-09-05 16:41:39 PDT

Comment on attachment 237716 [details]
proposed patch

I need to think more about this.

Getting a result for a newer build doesn't mean that you have a result for an older build - e.g. the new build could fail due to a new mistaken commit, so you don't know if your commit was the one that introduced the problem.

Comment 3 Alexey Proskuryakov 2014-09-07 23:18:16 PDT

Considering how we use the dashboard, I think that this patch was right. We do not wait for all results for the bots to tell us which commit caused the problem - we just see the red, and analyze the breakage ourselves.

However, I'm going to include this change into a different patch.