Bug 136579

Summary: Move CallFrame and Register inlines functions out of JSScope.h
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kangil.han, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 136649    
Bug Blocks:    
Attachments:
Description Flags
the patch
mark.lam: review-
patch 2: +WebCore build fixes.
none
patch 3: one more WebCore build fix ggaren: review+

Description Mark Lam 2014-09-05 10:58:08 PDT 
This include fixing up some files to #include JSCInlines.h to pick up these inline functions.  I also added JSCellInlines.h to JSCInlines.h since it is included from many of the affected .cpp files.
Comment 1 Mark Lam 2014-09-05 11:06:22 PDT 
Created attachment 237700 [details]
the patch
Comment 2 Geoffrey Garen 2014-09-05 11:58:22 PDT 
Comment on attachment 237700 [details]
the patch

r=me
Comment 3 Mark Lam 2014-09-05 18:26:10 PDT 
Comment on attachment 237700 [details]
the patch

WebCore side needed a lot of work with #includes.  I’ll upload an updated patch with WebCore changes once I’m done rebuilding the world.
Comment 4 Mark Lam 2014-09-05 22:25:05 PDT 
Created attachment 237729 [details]
patch 2: +WebCore build fixes.
Comment 5 Mark Lam 2014-09-08 15:25:17 PDT 
Created attachment 237815 [details]
patch 3: one more WebCore build fix
Comment 6 Geoffrey Garen 2014-09-08 15:52:08 PDT 
Comment on attachment 237815 [details]
patch 3: one more WebCore build fix

r=me
Comment 7 Mark Lam 2014-09-08 16:00:08 PDT 
Thanks for the review.  Landed in r173402: <http://trac.webkit.org/r173402>.
Comment 8 WebKit Commit Bot 2014-09-08 17:17:07 PDT 
Re-opened since this is blocked by bug 136649