Bug 136565

Summary: ARM: Add more coverage to ARMv7 disassembler
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Fixed style issues mark.lam: review+

Michael Saboff
Reported 2014-09-04 19:48:26 PDT
As part of debugging <https://bugs.webkit.org/show_bug.cgi?id=136261> - "ARM32 iOS: JSC Test math.js fails", several instructions where not being disassembled. Added support for the missing instructions.
Attachments
Patch (12.48 KB, patch)
2014-09-04 20:01 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Fixed style issues (12.47 KB, patch)
2014-09-04 20:08 PDT, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2014-09-04 20:01:57 PDT
Created attachment 237672 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-04 20:03:42 PDT
Attachment 237672 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1561: Extra space before ) [whitespace/parens] [2] ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1565: Extra space before ) [whitespace/parens] [2] ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1567: Extra space before ) [whitespace/parens] [2] ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1588: Extra space before ) [whitespace/parens] [2] ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1593: Extra space before ) [whitespace/parens] [2] ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1604: Extra space before ) [whitespace/parens] [2] ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1606: Extra space before ) [whitespace/parens] [2] Total errors found: 7 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 3 2014-09-04 20:08:58 PDT
Created attachment 237673 [details] Fixed style issues
Mark Lam
Comment 4 2014-09-05 08:25:43 PDT
Comment on attachment 237673 [details] Fixed style issues rs=me
Michael Saboff
Comment 5 2014-09-05 09:17:34 PDT
Committed r173312: <http://trac.webkit.org/changeset/173312>
Note You need to log in before you can comment on or make changes to this bug.