Bug 136565 - ARM: Add more coverage to ARMv7 disassembler
Summary: ARM: Add more coverage to ARMv7 disassembler
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
Depends on:
Reported: 2014-09-04 19:48 PDT by Michael Saboff
Modified: 2014-09-05 09:17 PDT (History)
1 user (show)

See Also:

Patch (12.48 KB, patch)
2014-09-04 20:01 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff
Fixed style issues (12.47 KB, patch)
2014-09-04 20:08 PDT, Michael Saboff
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-09-04 19:48:26 PDT
As part of debugging <https://bugs.webkit.org/show_bug.cgi?id=136261> - "ARM32 iOS: JSC Test math.js fails", several instructions where not being disassembled.

Added support for the missing instructions.
Comment 1 Michael Saboff 2014-09-04 20:01:57 PDT
Created attachment 237672 [details]
Comment 2 WebKit Commit Bot 2014-09-04 20:03:42 PDT
Attachment 237672 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1561:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1565:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1567:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1588:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1593:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1604:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/JavaScriptCore/disassembler/ARMv7/ARMv7DOpcode.cpp:1606:  Extra space before )  [whitespace/parens] [2]
Total errors found: 7 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Saboff 2014-09-04 20:08:58 PDT
Created attachment 237673 [details]
Fixed style issues
Comment 4 Mark Lam 2014-09-05 08:25:43 PDT
Comment on attachment 237673 [details]
Fixed style issues

Comment 5 Michael Saboff 2014-09-05 09:17:34 PDT
Committed r173312: <http://trac.webkit.org/changeset/173312>