Bug 136559

Summary:

Dashboard metrics page wastes a lot of time sorting iterations

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	thorton: review+

Alexey Proskuryakov

Reported 2014-09-04 17:09:21 PDT

We now re-sort iterations array for every iteration that is parsed, which makes no sense at all. Especially because we don't even end up with a sorted array, as we sort it before adding to it. This only affects the metrics page, not the regular dashboard which updates previously shallowly loaded iterations in place.

Attachments
proposed fix (3.76 KB, patch) 2014-09-04 18:10 PDT, Alexey Proskuryakov	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2014-09-04 18:10:14 PDT

Created attachment 237665 [details] proposed fix

Alexey Proskuryakov

Comment 2 2014-09-05 12:09:29 PDT

Committed <http://trac.webkit.org/r173322>.

Note You need to log in before you can comment on or make changes to this bug.