Bug 136559 - Dashboard metrics page wastes a lot of time sorting iterations
Summary: Dashboard metrics page wastes a lot of time sorting iterations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 17:09 PDT by Alexey Proskuryakov
Modified: 2014-09-05 12:09 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (3.76 KB, patch)
2014-09-04 18:10 PDT, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-09-04 17:09:21 PDT 
We now re-sort iterations array for every iteration that is parsed, which makes no sense at all. Especially because we don't even end up with a sorted array, as we sort it before adding to it.

This only affects the metrics page, not the regular dashboard which updates previously shallowly loaded iterations in place.
Comment 1 Alexey Proskuryakov 2014-09-04 18:10:14 PDT 
Created attachment 237665 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2014-09-05 12:09:29 PDT 
Committed <http://trac.webkit.org/r173322>.