Bug 13654

Summary: REGRESSION: Fieldset stretches too much because minwidth is wrong.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P1    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Reduction
none
This fixes it.
none
Better patch. mitz: review+

Description Dave Hyatt 2007-05-10 04:37:03 PDT
In the attached test case, the fieldset has a minwidth that is bigger than other browsers.  Clear whitespace breaking opportunities exist, and yet they are somehow not being factored into the minwidth.

This is a regression caused by

http://bugs.webkit.org/show_bug.cgi?id=8438

although I think it just exposed a min width bug.
Comment 1 Dave Hyatt 2007-05-10 04:37:52 PDT
Created attachment 14457 [details]
Reduction

Reduction.
Comment 2 Dave Hyatt 2007-05-10 04:38:30 PDT
<rdar://problem/5146757>
Comment 3 Dave Hyatt 2007-05-10 05:08:28 PDT
Created attachment 14459 [details]
This fixes it.

Any text run that gets thoroughly ignored but that contains only stripped out whitespace will have beginWS and endWS set to true.  Combine that with autoWrap and you know when a break opportunity exists.
Comment 4 Dave Hyatt 2007-05-10 05:20:43 PDT
Created attachment 14460 [details]
Better patch.

After conversation with mitz on IRC, new patch.
Comment 5 mitz 2007-05-10 05:22:01 PDT
Comment on attachment 14460 [details]
Better patch.

r=me. fix indentation of the first 'if'!
Comment 6 Dave Hyatt 2007-05-10 05:30:19 PDT
Fixed in r21365.