Bug 136539

Summary: REGRESSION: Dashboard metrics page aggregation counts performance bots
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dburkart, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Description Alexey Proskuryakov 2014-09-04 11:54:12 PDT 
The dashboard metrics page doesn't show performance bots on the grid, so it's unexpected that their results are taken into account at all.

Furthermore, waiting for performance bots to cycle is not generally considered as part of due diligence after landing a patch, so performance bots should not be included in the elapsed time anyway. It's arguable whether they should be included in red/green time.
Comment 1 Alexey Proskuryakov 2014-09-04 11:56:47 PDT 
Created attachment 237637 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-09-04 13:01:49 PDT 
Comment on attachment 237637 [details]
proposed fix

Clearing flags on attachment: 237637

Committed r173273: <http://trac.webkit.org/changeset/173273>
Comment 3 WebKit Commit Bot 2014-09-04 13:01:51 PDT 
All reviewed patches have been landed.  Closing bug.