Bug 136535

Summary:

Allow pages with unload handlers in the page cache

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

Page Loading

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	none

Description Brady Eidson 2014-09-04 10:44:16 PDT

Allow pages with unload handlers in the page cache.

It's 2014.  unload events served their purpose a decade ago, but we've had pagehide for years to overcome unload's shortcomings.

Let's stop letting the mere existence of an unload handler kill an import performance enhancement, and willfully break unload semantics instead.

<rdar://problem/11084669>

Comment 1 Brady Eidson 2014-09-04 14:24:12 PDT

Created attachment 237647 [details]
Patch v1 

Ran tests locally, but not confident in my findings - This is for EWS

Comment 2 Brady Eidson 2014-09-05 14:30:22 PDT

This should be fine, let's review it and land it.

Comment 3 WebKit Commit Bot 2014-09-05 15:11:27 PDT

Comment on attachment 237647 [details]
Patch v1 

Clearing flags on attachment: 237647

Committed r173336: <http://trac.webkit.org/changeset/173336>

Comment 4 WebKit Commit Bot 2014-09-05 15:11:29 PDT

All reviewed patches have been landed.  Closing bug.