Initial letters should clear one another

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dave Hyatt]

Initial letters should clear one another so that short paragraphs don't result in first letters getting jumbled up.

[Dave Hyatt]

Created attachment 237599 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 237599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237599&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:2304
> +    bool isInitialLetter = childBox.style().styleType() == FIRST_LETTER && childBox.style().initialLetterDrop() > 0;

Seems like this could be an inline function on RenderStyle.

> Source/WebCore/rendering/RenderBlockFlow.cpp:2576
> +    const FloatingObjectSet& floatingObjectSet = m_floatingObjects->set();

auto?

> Source/WebCore/rendering/RenderBlockFlow.cpp:2580
> +        if (floatingObject->isPlaced() && floatingObject->renderer().style().styleType() == FIRST_LETTER && floatingObject->renderer().style().initialLetterDrop() > 0)

Then you could say floatingObject->renderer().style().hasInitialLetter() here.

[Dave Hyatt]

Not going to add the method to RenderStyle, but only because next patch will add support for initial-letter on things other than first letters, and at that point just checking the property itself (without checking first letter any longer) will be sufficient.

[Radar WebKit Bug Importer]

<rdar://problem/18941425>

[Jon Lee]

Changelist 173281