Bug 136507

Summary: Make images work with patches created using svn 1.7
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, darin, dbates, dfarler, hyatt, joepeck, mrobinson, ossy, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2014-09-03 15:17:54 PDT 
Subversion 1.7 does this crazy thing where it emits a text patch for the property changes of a newly added image, immediately after the original "diff" header:

Index: simple-gradients-expected.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: simple-gradients-expected.png
===================================================================
--- simple-gradients-expected.png	(revision 0)
+++ simple-gradients-expected.png	(working copy)

Property changes on: simple-gradients-expected.png
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+application/octet-stream
\ No newline at end of property

This greatly confuses PrettyPatch.rb because the first patch looked like the image was being removed, and the second patch looked like normal diff (until the blank line and the property changes are hit).
Comment 1 David Kilzer (:ddkilzer) 2014-09-03 15:27:58 PDT 
Created attachment 237590 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-09-03 23:46:58 PDT 
Comment on attachment 237590 [details]
Patch v1

Clearing flags on attachment: 237590

Committed r173253: <http://trac.webkit.org/changeset/173253>
Comment 3 WebKit Commit Bot 2014-09-03 23:47:02 PDT 
All reviewed patches have been landed.  Closing bug.