Bug 136507 - Make images work with patches created using svn 1.7
Summary: Make images work with patches created using svn 1.7
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Reported: 2014-09-03 15:17 PDT by David Kilzer (:ddkilzer)
Modified: 2014-09-03 23:47 PDT (History)
10 users (show)

See Also:

Patch v1 (5.67 KB, patch)
2014-09-03 15:27 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-09-03 15:17:54 PDT
Subversion 1.7 does this crazy thing where it emits a text patch for the property changes of a newly added image, immediately after the original "diff" header:

Index: simple-gradients-expected.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: simple-gradients-expected.png
--- simple-gradients-expected.png	(revision 0)
+++ simple-gradients-expected.png	(working copy)

Property changes on: simple-gradients-expected.png
Added: svn:mime-type
## -0,0 +1 ##
\ No newline at end of property

This greatly confuses PrettyPatch.rb because the first patch looked like the image was being removed, and the second patch looked like normal diff (until the blank line and the property changes are hit).
Comment 1 David Kilzer (:ddkilzer) 2014-09-03 15:27:58 PDT
Created attachment 237590 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-09-03 23:46:58 PDT
Comment on attachment 237590 [details]
Patch v1

Clearing flags on attachment: 237590

Committed r173253: <http://trac.webkit.org/changeset/173253>
Comment 3 WebKit Commit Bot 2014-09-03 23:47:02 PDT
All reviewed patches have been landed.  Closing bug.