| Summary: | Delete class SavedDrawingStateForMask | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | Layout and Rendering | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, schenney, sergio, simon.fraser, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2014-09-03 14:11:23 PDT
Created attachment 237858 [details]
Patch
Attachment 237858 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/TextPainter.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 237868 [details]
Patch
Attachment 237868 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/TextPainter.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Style error is a false positive. Comment on attachment 237868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237868&action=review > Source/WebCore/rendering/TextPainter.cpp:139 > + TextRun& emphasisMarkTextRun = m_combinedText ? static_cast<TextRun&>(objectReplacementCharacterTextRun) : m_textRun; Instead of: static_cast<TextRun&>(objectReplacementCharacterTextRun) Should use: objectReplacementCharacterTextRun.get() Comment on attachment 237868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237868&action=review >> Source/WebCore/rendering/TextPainter.cpp:139 >> + TextRun& emphasisMarkTextRun = m_combinedText ? static_cast<TextRun&>(objectReplacementCharacterTextRun) : m_textRun; > > Instead of: > > static_cast<TextRun&>(objectReplacementCharacterTextRun) > > Should use: > > objectReplacementCharacterTextRun.get() Done. |