Bug 136498

Summary: Delete class SavedDrawingStateForMask
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, schenney, sergio, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Myles C. Maxfield
Reported 2014-09-03 14:11:23 PDT
It is unnecessary.
Attachments
Patch (19.65 KB, patch)
2014-09-09 14:43 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (19.86 KB, patch)
2014-09-09 16:03 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-09-09 14:43:18 PDT
Created attachment 237858 [details] Patch
WebKit Commit Bot
Comment 2 2014-09-09 14:44:59 PDT
Attachment 237858 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/TextPainter.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 3 2014-09-09 16:03:17 PDT
Created attachment 237868 [details] Patch
WebKit Commit Bot
Comment 4 2014-09-09 16:06:07 PDT
Attachment 237868 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/TextPainter.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 5 2014-09-09 17:06:31 PDT
Style error is a false positive.
Darin Adler
Comment 6 2014-09-10 08:34:53 PDT
Comment on attachment 237868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237868&action=review > Source/WebCore/rendering/TextPainter.cpp:139 > + TextRun& emphasisMarkTextRun = m_combinedText ? static_cast<TextRun&>(objectReplacementCharacterTextRun) : m_textRun; Instead of: static_cast<TextRun&>(objectReplacementCharacterTextRun) Should use: objectReplacementCharacterTextRun.get()
Myles C. Maxfield
Comment 7 2014-09-10 17:16:16 PDT
Comment on attachment 237868 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237868&action=review >> Source/WebCore/rendering/TextPainter.cpp:139 >> + TextRun& emphasisMarkTextRun = m_combinedText ? static_cast<TextRun&>(objectReplacementCharacterTextRun) : m_textRun; > > Instead of: > > static_cast<TextRun&>(objectReplacementCharacterTextRun) > > Should use: > > objectReplacementCharacterTextRun.get() Done.
Myles C. Maxfield
Comment 8 2014-09-10 17:50:38 PDT
https://trac.webkit.org/r173502
Note You need to log in before you can comment on or make changes to this bug.