Bug 136491

Summary: Get rid of HIGH_DPI_CANVAS leftovers
Product: WebKit Reporter: mitz
Component: CanvasAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rakuco, roger_fong, ryuan.choi, sergio, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
I. Remove EANBLE_HIGH_DPI_CANVAS
benjamin: review+
II. Remove HTMLCanvasElement::deviceScaleFactor() benjamin: review+

mitz
Reported 2014-09-03 11:56:22 PDT
The HIGH_DPI_CANVAS feature is not enabled in any configuration.
Attachments
I. Remove EANBLE_HIGH_DPI_CANVAS (33.47 KB, patch)
2014-09-03 12:00 PDT, mitz 		benjamin: review+
DetailsFormatted DiffDiff
II. Remove HTMLCanvasElement::deviceScaleFactor() (8.84 KB, patch)
2014-09-03 13:35 PDT, mitz 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-09-03 12:00:45 PDT
Created attachment 237567 [details] I. Remove EANBLE_HIGH_DPI_CANVAS
Benjamin Poulain
Comment 2 2014-09-03 12:16:24 PDT
Comment on attachment 237567 [details] I. Remove EANBLE_HIGH_DPI_CANVAS View in context: https://bugs.webkit.org/attachment.cgi?id=237567&action=review > Source/WebCore/html/HTMLCanvasElement.cpp:351 > float HTMLCanvasElement::targetDeviceScaleFactor() const Can't you remove all the "target device scale factor" stuff from canvas?
mitz
Comment 3 2014-09-03 12:16:59 PDT
(In reply to comment #2) > (From update of attachment 237567 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237567&action=review > > > Source/WebCore/html/HTMLCanvasElement.cpp:351 > > float HTMLCanvasElement::targetDeviceScaleFactor() const > > Can't you remove all the "target device scale factor" stuff from canvas? I can.
mitz
Comment 4 2014-09-03 12:18:25 PDT
Committed attachment 237567 [details] as <http://trac.webkit.org/r173215>.
mitz
Comment 5 2014-09-03 13:35:39 PDT
Created attachment 237577 [details] II. Remove HTMLCanvasElement::deviceScaleFactor()
Benjamin Poulain
Comment 6 2014-09-03 14:28:46 PDT
Comment on attachment 237577 [details] II. Remove HTMLCanvasElement::deviceScaleFactor() Neat!
mitz
Comment 7 2014-09-04 01:28:57 PDT
Committed attachment 237577 [details] as <http://trac.webkit.org/r173256>.
Note You need to log in before you can comment on or make changes to this bug.