Bug 136490

Summary: CallEdgeProfile::visitWeak() should gracefully handle the case where primaryCallee duplicates an entry in otherCallees
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2014-09-03 11:48:38 PDT
Patch forthcoming.
Attachments
the patch (2.02 KB, patch)
2014-09-03 11:49 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-09-03 11:49:26 PDT
Created attachment 237566 [details] the patch
Geoffrey Garen
Comment 2 2014-09-03 11:52:02 PDT
Comment on attachment 237566 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=237566&action=review r=me > Source/JavaScriptCore/bytecode/CallEdgeProfile.cpp:143 > + // the primary culd duplicate an entry in otherCallees, which means that even though we "could"
Filip Pizlo
Comment 3 2014-09-03 11:58:44 PDT
Landed in http://trac.webkit.org/changeset/173214
Note You need to log in before you can comment on or make changes to this bug.