Bug 136486 – [Win] Revise test environment for Windows build

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

The Windows build and test system has some cruft that needs to be cleaned up:
1. DRT and friends know how to find 64-bit runtimes, so the special cases in webkitdirs.pm should be removed.
2. We don't need to look for Safari.exe on Windows to run tests, and shouldn't complain if we don't find it.
3. Where possible, we should use File::Spec for file handling so that we can be agnostic about whether the tests are being run under Cygwin or not.

[Brent Fulgham]

Created attachment 237562 [details]
Patch

[Brent Fulgham]

*** Bug 125180 has been marked as a duplicate of this bug. ***

[Brent Fulgham]

I didn't actually make any File::Spec changes here. That will be coming in a separate change.

[David Kilzer (:ddkilzer)]

Comment on attachment 237562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237562&action=review

r=me

> Tools/Scripts/webkitdirs.pm:765
> +    die "Safari Path is only relevant on Mac platform\n" unless isAppleMacWebKit();

Nit:  Lowercase "Path"?  Maybe say instead:

    die "Safari path is only relevant on Apple Mac platform\n" unless isAppleMacWebKit();

> Tools/Scripts/webkitdirs.pm:784
> +    die "Safari Path is only relevant on Mac platform\n" unless isAppleMacWebKit();

Same:

    die "Safari path is only relevant on Apple Mac platform\n" unless isAppleMacWebKit();

[Brent Fulgham]

Committed r173219: <http://trac.webkit.org/changeset/173219>