Bug 136481

Summary: [WinCairo] jsc.exe won't run.
Product: WebKit Reporter: peavo
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2014-09-03 06:01:10 PDT
I get the message "Failed to determine path to AAS directory". We need to define WIN_CAIRO.
Attachments
Patch (3.22 KB, patch)
2014-09-03 06:05 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (10.48 KB, patch)
2014-09-03 13:12 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2014-09-03 06:05:54 PDT
Created attachment 237559 [details] Patch
Alex Christensen
Comment 2 2014-09-03 07:23:55 PDT
Comment on attachment 237559 [details] Patch Let's do the same thing as WinLauncher and DumpRenderTree and import DLLLauncherWinCairo.props instead.
peavo
Comment 3 2014-09-03 13:12:11 PDT
Created attachment 237575 [details] Patch
peavo
Comment 4 2014-09-03 13:13:51 PDT
(In reply to comment #2) > (From update of attachment 237559 [details]) > Let's do the same thing as WinLauncher and DumpRenderTree and import DLLLauncherWinCairo.props instead. Thanks for reviewing, updated patch accordingly :) I made a copy of DLLLauncherWinCairo.props to avoid cross-module dependencies.
Alex Christensen
Comment 5 2014-09-05 12:05:19 PDT
Comment on attachment 237575 [details] Patch There is already a copy of DLLLauncherMain.cpp from Tools/win/DLLLauncher to Source/JavaScriptCore/JavaScriptCore.vcxproj/jsc. As much as I don't like duplicate code, this follows that pattern.
WebKit Commit Bot
Comment 6 2014-09-05 12:42:17 PDT
Comment on attachment 237575 [details] Patch Clearing flags on attachment: 237575 Committed r173327: <http://trac.webkit.org/changeset/173327>
WebKit Commit Bot
Comment 7 2014-09-05 12:42:20 PDT
All reviewed patches have been landed. Closing bug.
peavo
Comment 8 2014-09-05 13:02:59 PDT
(In reply to comment #5) > (From update of attachment 237575 [details]) > There is already a copy of DLLLauncherMain.cpp from Tools/win/DLLLauncher to Source/JavaScriptCore/JavaScriptCore.vcxproj/jsc. As much as I don't like duplicate code, this follows that pattern. Thanks for reviewing :)
Note You need to log in before you can comment on or make changes to this bug.