Bug 136476

Summary: Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch timothy: review+

Brian Burg
Reported 2014-09-02 22:27:14 PDT
follow the rules!
Attachments
Patch (91.27 KB, patch)
2014-09-02 22:43 PDT, Brian Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-09-02 22:27:21 PDT
<rdar://problem/18210878>
Brian Burg
Comment 2 2014-09-02 22:43:09 PDT
Created attachment 237548 [details] Patch
WebKit Commit Bot
Comment 3 2014-09-02 22:45:24 PDT
Attachment 237548 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp:73: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Timothy Hatcher
Comment 4 2014-09-02 22:51:33 PDT
Comment on attachment 237548 [details] Patch Let see what Joe thinks about the change before landing.
Brian Burg
Comment 5 2014-09-02 23:13:18 PDT
Comment on attachment 237548 [details] Patch In particular, whether Page::console() or Page::consoleClient() is better. Both options read well in different places.
Brian Burg
Comment 6 2014-09-03 22:53:53 PDT
Committed r173251: <http://trac.webkit.org/changeset/173251>
Note You need to log in before you can comment on or make changes to this bug.