Bug 136476

Summary:

Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	timothy: review+

Description Brian Burg 2014-09-02 22:27:14 PDT

follow the rules!

Comment 1 Radar WebKit Bug Importer 2014-09-02 22:27:21 PDT

<rdar://problem/18210878>

Comment 2 Brian Burg 2014-09-02 22:43:09 PDT

Created attachment 237548 [details]
Patch

Comment 3 WebKit Commit Bot 2014-09-02 22:45:24 PDT

Attachment 237548 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp:73:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Timothy Hatcher 2014-09-02 22:51:33 PDT

Comment on attachment 237548 [details]
Patch

Let see what Joe thinks about the change before landing.

Comment 5 Brian Burg 2014-09-02 23:13:18 PDT

Comment on attachment 237548 [details]
Patch

In particular, whether Page::console() or Page::consoleClient() is better. Both options read well in different places.

Comment 6 Brian Burg 2014-09-03 22:53:53 PDT

Committed r173251: <http://trac.webkit.org/changeset/173251>