Bug 136476 - Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
Summary: Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
Keywords: InRadar
Depends on:
Reported: 2014-09-02 22:27 PDT by Brian Burg
Modified: 2014-09-03 22:53 PDT (History)
5 users (show)

See Also:

Patch (91.27 KB, patch)
2014-09-02 22:43 PDT, Brian Burg
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-09-02 22:27:14 PDT
follow the rules!
Comment 1 Radar WebKit Bug Importer 2014-09-02 22:27:21 PDT
Comment 2 Brian Burg 2014-09-02 22:43:09 PDT
Created attachment 237548 [details]
Comment 3 WebKit Commit Bot 2014-09-02 22:45:24 PDT
Attachment 237548 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp:73:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 35 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Timothy Hatcher 2014-09-02 22:51:33 PDT
Comment on attachment 237548 [details]

Let see what Joe thinks about the change before landing.
Comment 5 Brian Burg 2014-09-02 23:13:18 PDT
Comment on attachment 237548 [details]

In particular, whether Page::console() or Page::consoleClient() is better. Both options read well in different places.
Comment 6 Brian Burg 2014-09-03 22:53:53 PDT
Committed r173251: <http://trac.webkit.org/changeset/173251>