Bug 136470

Summary:

Use StringBuilder append(char) and appendLiteral in more places

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-09-02 16:07:27 PDT

Use StringBuilder::append(char) and StringBuilder::appendLiteral in more places. I checked `binaryinfo $build/Release/WebCore.framework/WebCore` before and after my change and it was the same: > TEXT SIZE DATA SIZE OBJC SIZE OTHR SIZE EXPORTS LINKAGE NAMESPACE PREBOUND BINARY > ========= ========= ========= ========= ======= ======= ========= ======== ========== > 16500 KB 1852 KB 0 KB 18192 KB 2921 -n TOO MUCH

Attachments
[PATCH] Proposed Fix (32.99 KB, patch) 2014-09-02 16:09 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2014-09-02 16:09:31 PDT

Created attachment 237525 [details] [PATCH] Proposed Fix

Andreas Kling

Comment 2 2014-09-03 10:35:19 PDT

Comment on attachment 237525 [details] [PATCH] Proposed Fix r=me

WebKit Commit Bot

Comment 3 2014-09-03 11:43:06 PDT

Comment on attachment 237525 [details] [PATCH] Proposed Fix Clearing flags on attachment: 237525 Committed r173212: <http://trac.webkit.org/changeset/173212>

WebKit Commit Bot

Comment 4 2014-09-03 11:43:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.