Bug 136463

Summary: Use references in public EventSender functions
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, dino, esprehn+autocc, gyuyoung.kim, japhet, jonlee, kangil.han, kling, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Description Myles C. Maxfield 2014-09-02 13:51:11 PDT 
Use references in public EventSender functions
Comment 1 Myles C. Maxfield 2014-09-02 13:52:47 PDT 
Created attachment 237512 [details]
Patch
Comment 2 Daniel Bates 2014-09-02 14:20:51 PDT 
Comment on attachment 237512 [details]
Patch

r=me
Comment 3 Daniel Bates 2014-09-02 14:22:46 PDT 
Comment on attachment 237512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237512&action=review

> Source/WebCore/dom/EventSender.h:78
>      size_t size = m_dispatchSoonList.size();
>      for (size_t i = 0; i < size; ++i) {

Nit: We should update this code to use a C++11 range-for loop.

> Source/WebCore/dom/EventSender.h:103
>      size_t size = m_dispatchingList.size();
>      for (size_t i = 0; i < size; ++i) {

Ditto.
Comment 4 Myles C. Maxfield 2014-09-03 13:47:04 PDT 
http://trac.webkit.org/changeset/173190