Bug 136462

Summary:

Web Inspector: remove ProfilerAgent and legacy profiler files in the frontend

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, gyuyoung.kim, joepeck, rakuco, ryuan.choi, sergio, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

136380

Attachments:

Description	Flags
Proposed fix	timothy: review+

Description Brian Burg 2014-09-02 13:47:11 PDT

They are not used anywhere.

Comment 1 Radar WebKit Bug Importer 2014-09-02 13:47:44 PDT

<rdar://problem/18204711>

Comment 2 Brian Burg 2014-09-02 16:34:40 PDT

Created attachment 237530 [details]
Proposed fix

Comment 3 Timothy Hatcher 2014-09-02 16:51:31 PDT

Comment on attachment 237530 [details]
Proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237530&action=review

> Source/WebCore/inspector/protocol/Timeline.json:50
> +                { "name": "idleTime", "type": "number", "optional": true }

Didn't you remove this in another patch?

Comment 4 Brian Burg 2014-09-02 17:04:30 PDT

(In reply to comment #3)
> (From update of attachment 237530 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=237530&action=review
> 
> > Source/WebCore/inspector/protocol/Timeline.json:50
> > +                { "name": "idleTime", "type": "number", "optional": true }
> 
> Didn't you remove this in another patch?

Yes, going to land this one first though once EWS is done.

Comment 5 Brian Burg 2014-09-02 20:17:58 PDT

Committed r173198: <http://trac.webkit.org/changeset/173198>