Bug 136458

Summary: Optimize own property GetByVals with rope string subscripts.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2014-09-02 10:57:44 PDT
Patch forthcoming.
Attachments
Patch (12.11 KB, patch)
2014-09-02 10:58 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-09-02 10:58:36 PDT
Created attachment 237505 [details] Patch
Geoffrey Garen
Comment 2 2014-09-02 12:42:46 PDT
Comment on attachment 237505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237505&action=review r=me > Source/JavaScriptCore/dfg/DFGOperations.cpp:300 > + if (AtomicStringImpl* existingAtomicString = asString(property)->toExistingAtomicString(exec)) { This is a clever observation. I wonder if we should build it into JSObject, by providing a (fast?)getOwnProperty() that takes a JSString* argument. That would simplify some of the call sites, and it would encourage folks writing code that used JSString* to do the right thing by default.
Andreas Kling
Comment 3 2014-09-02 15:30:20 PDT
Comment on attachment 237505 [details] Patch Clearing flags on attachment: 237505 Committed r173188: <http://trac.webkit.org/changeset/173188>
Andreas Kling
Comment 4 2014-09-02 15:30:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.