Bug 136458

Summary:

Optimize own property GetByVals with rope string subscripts.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

JavaScriptCore

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kling

Priority:

Keywords:

Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Andreas Kling 2014-09-02 10:57:44 PDT

Patch forthcoming.

Comment 1 Andreas Kling 2014-09-02 10:58:36 PDT

Created attachment 237505 [details]
Patch

Comment 2 Geoffrey Garen 2014-09-02 12:42:46 PDT

Comment on attachment 237505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237505&action=review

r=me

> Source/JavaScriptCore/dfg/DFGOperations.cpp:300
> +                if (AtomicStringImpl* existingAtomicString = asString(property)->toExistingAtomicString(exec)) {

This is a clever observation. I wonder if we should build it into JSObject, by providing a (fast?)getOwnProperty() that takes a JSString* argument. That would simplify some of the call sites, and it would encourage folks writing code that used JSString* to do the right thing by default.

Comment 3 Andreas Kling 2014-09-02 15:30:20 PDT

Comment on attachment 237505 [details]
Patch

Clearing flags on attachment: 237505

Committed r173188: <http://trac.webkit.org/changeset/173188>

Comment 4 Andreas Kling 2014-09-02 15:30:22 PDT

All reviewed patches have been landed.  Closing bug.