| Summary: | Clean up naming for and slightly refactor legacy video fullscreen support | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||||||||||||
| Component: | New Bugs | Assignee: | Maciej Stachowiak <mjs> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jeremyj-wk, jer.noble, jonlee, philipj, sergio, thorton | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Maciej Stachowiak
2014-09-02 00:43:14 PDT
Created attachment 237481 [details]
Patch
Attachment 237481 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:41: "WebCore/HTMLVideoElement.h" already included at Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:40 [build/include] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:47: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm:57: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebKit/mac/WebView/WebView.mm:137: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5]
Total errors found: 5 in 31 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 237507 [details]
Patch
Created attachment 237510 [details]
Rebaselined to newer trunk
Attachment 237510 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebView.mm:137: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5]
Total errors found: 2 in 31 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 237523 [details]
Attempt to fix Windows build
Attachment 237523 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebView/WebView.mm:137: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5]
Total errors found: 2 in 31 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 237538 [details]
Patch
Attachment 237538 [details] did not pass style-queue:
ERROR: Source/WebCore/WebCore.exp.in:0: Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script [list/order] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5]
Total errors found: 2 in 33 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 237549 [details]
Try to fix Windows build again
Attachment 237549 [details] did not pass style-queue:
ERROR: Source/WebCore/WebCore.exp.in:0: Source/WebCore/WebCore.exp.in should be sorted, use Tools/Scripts/sort-export-file script [list/order] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.h:819: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5]
Total errors found: 2 in 33 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 237549 [details]
Try to fix Windows build again
There's a lot of really good refactoring in here. r=me
Committed r173230: <http://trac.webkit.org/changeset/173230> Slightly weird iOS build fix in http://trac.webkit.org/changeset/173243 |