| Summary: | Make DrawingArea a real MessageReceiver | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, mitz, mkwst, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-09-01 15:41:01 PDT
Created attachment 237466 [details]
Patch
Comment on attachment 237466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61 > +class DrawingArea : public IPC::MessageReceiver { Can this derive privately instead of publicly? Just wondering. Comment on attachment 237466 [details]
Patch
Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose.
(In reply to comment #3) > (From update of attachment 237466 [details]) > Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose. It's one of these: c++: internal compiler error: Killed (program cc1plus) which tend (usually) not to be the patch's fault. (In reply to comment #2) > (From update of attachment 237466 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review > > > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61 > > +class DrawingArea : public IPC::MessageReceiver { > > Can this derive privately instead of publicly? Just wondering. I don't think so, because MessageReceiverMap and friends need to be able to call the MessageReceiver functions. In any case, there's no precedent. |