Bug 136438

Summary: Make DrawingArea a real MessageReceiver
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, mkwst, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Tim Horton
Reported 2014-09-01 15:41:01 PDT
Make DrawingArea a real MessageReceiver
Attachments
Patch (6.79 KB, patch)
2014-09-01 15:41 PDT, Tim Horton 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-09-01 15:41:38 PDT
Created attachment 237466 [details] Patch
Darin Adler
Comment 2 2014-09-04 01:23:43 PDT
Comment on attachment 237466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61 > +class DrawingArea : public IPC::MessageReceiver { Can this derive privately instead of publicly? Just wondering.
Darin Adler
Comment 3 2014-09-04 01:24:14 PDT
Comment on attachment 237466 [details] Patch Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose.
Tim Horton
Comment 4 2014-09-09 08:34:36 PDT
(In reply to comment #3) > (From update of attachment 237466 [details]) > Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose. It's one of these: c++: internal compiler error: Killed (program cc1plus) which tend (usually) not to be the patch's fault.
Tim Horton
Comment 5 2014-09-09 08:49:19 PDT
(In reply to comment #2) > (From update of attachment 237466 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review > > > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61 > > +class DrawingArea : public IPC::MessageReceiver { > > Can this derive privately instead of publicly? Just wondering. I don't think so, because MessageReceiverMap and friends need to be able to call the MessageReceiver functions. In any case, there's no precedent.
Tim Horton
Comment 6 2014-09-09 08:58:29 PDT
http://trac.webkit.org/changeset/173429
Note You need to log in before you can comment on or make changes to this bug.