| Summary: | Remove unused ARMv6-specific #if branches in WebCore::canHyphenate | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, benjamin, mitz, psolanki | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-08-31 18:03:28 PDT
Created attachment 237438 [details]
Patch
Comment on attachment 237438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237438&action=review > Source/WebCore/ChangeLog:10 > + Use kCFAllocatorDefault instead of 0. Do we do that? I thought that 0 was better in nearly every respect - shorter and faster. (In reply to comment #3) > (From update of attachment 237438 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237438&action=review > > > Source/WebCore/ChangeLog:10 > > + Use kCFAllocatorDefault instead of 0. > > Do we do that? I thought that 0 was better in nearly every respect - shorter and faster. Perhaps, but also completely mysterious when reading the code. We do need a certain level of C++ knowledge and platform savviness from contributors. I don't think that we have any who actually find this mysterious. I don't have any links, but I'm pretty sure that this was discussed before, and kCFAllocatorDefault was agreed unnecessary. |