Bug 136416

Summary: Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
Product: WebKit Reporter: Tim Horton <thorton>
Component: Layout and RenderingAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Tim Horton
Reported 2014-08-31 04:45:55 PDT
All of the callers only end up filling, and this function is pretty silly and not really in the right place.
Attachments
Patch (7.06 KB, patch)
2014-08-31 04:53 PDT, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-08-31 04:53:36 PDT
Created attachment 237426 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-31 04:54:43 PDT
Attachment 237426 [details] did not pass style-queue: ERROR: Source/WebKit/ios/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-08-31 15:06:49 PDT
http://trac.webkit.org/changeset/173150
Note You need to log in before you can comment on or make changes to this bug.