Bug 136416 - Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
Summary: Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-31 04:45 PDT by Tim Horton
Modified: 2014-08-31 15:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.06 KB, patch)
2014-08-31 04:53 PDT, Tim Horton
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-31 04:45:55 PDT
All of the callers only end up filling, and this function is pretty silly and not really in the right place.
Comment 1 Tim Horton 2014-08-31 04:53:36 PDT
Created attachment 237426 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-31 04:54:43 PDT
Attachment 237426 [details] did not pass style-queue:


ERROR: Source/WebKit/ios/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebCore/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-08-31 15:06:49 PDT
http://trac.webkit.org/changeset/173150