Bug 136413

Summary:

Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS) ifdefs

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, d-r, mitz, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
patch	mitz: review+

Description Tim Horton 2014-08-31 02:35:19 PDT

Remove duplicate implementation of drawEllipse and some related PLATFORM(IOS) ifdefs

Comment 1 Tim Horton 2014-08-31 02:35:36 PDT

Created attachment 237423 [details]
Patch

Comment 2 Tim Horton 2014-08-31 02:35:57 PDT

Have tested Mac, will test iOS as well shortly.

Comment 3 Tim Horton 2014-08-31 03:51:13 PDT

Hmm, nope, changes the rendering of radio buttons on iOS a little bit (border around the inner circle of a selected radio button grows a lot).

Comment 4 Tim Horton 2014-08-31 04:20:32 PDT

Created attachment 237425 [details]
patch

Actually, that was a preexisting issue with the initialization of the CGContext! (GraphicsContext line width defaults to 0, CGContext's to 1).

Going to need to run the layout tests now...

Comment 5 Tim Horton 2014-08-31 04:43:27 PDT

Layout tests are happy.

Comment 6 Tim Horton 2014-08-31 15:04:14 PDT

http://trac.webkit.org/changeset/173149