Bug 136408

Summary: SVGImage::drawPatternForContainer creates a buffer without respecting the destination's acceleration setting
Product: WebKit Reporter: Tim Horton <thorton>
Component: SVGAssignee: Tim Horton <thorton>
Severity: Normal CC: commit-queue, d-r, fmalita, gyuyoung.kim, mitz, pdr, schenney, sergio, simon.fraser, zimmermann
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
patch mitz: review+

Description Tim Horton 2014-08-30 22:23:35 PDT
Mismatched acceleration settings == terrible performance.

Comment 1 Tim Horton 2014-08-30 22:25:17 PDT
Created attachment 237419 [details]
Comment 2 WebKit Commit Bot 2014-08-30 22:27:32 PDT
Attachment 237419 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-08-31 00:04:05 PDT
Comment on attachment 237419 [details]

Any way to test this? Is this a performance enhancement or something else?
Comment 4 Tim Horton 2014-08-31 00:34:01 PDT
Just performance, no way to test (unless we were to add some mechanism to log when someone paints from an unaccelerated buffer to an accelerated context or vice versa, and then wrote some tests around that).
Comment 5 Tim Horton 2014-08-31 00:42:11 PDT