Bug 136408 - SVGImage::drawPatternForContainer creates a buffer without respecting the destination's acceleration setting
Summary: SVGImage::drawPatternForContainer creates a buffer without respecting the des...
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2014-08-30 22:23 PDT by Tim Horton
Modified: 2014-08-31 00:42 PDT (History)
10 users (show)

See Also:

patch (1.88 KB, patch)
2014-08-30 22:25 PDT, Tim Horton
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-30 22:23:35 PDT
Mismatched acceleration settings == terrible performance.

Comment 1 Tim Horton 2014-08-30 22:25:17 PDT
Created attachment 237419 [details]
Comment 2 WebKit Commit Bot 2014-08-30 22:27:32 PDT
Attachment 237419 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-08-31 00:04:05 PDT
Comment on attachment 237419 [details]

Any way to test this? Is this a performance enhancement or something else?
Comment 4 Tim Horton 2014-08-31 00:34:01 PDT
Just performance, no way to test (unless we were to add some mechanism to log when someone paints from an unaccelerated buffer to an accelerated context or vice versa, and then wrote some tests around that).
Comment 5 Tim Horton 2014-08-31 00:42:11 PDT