Bug 136384

Summary: Crashes in IPC code under VisitedLinkProvider::pendingVisitedLinksTimerFired
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, commit-queue, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
sam: review-
proposed fix sam: review+

Description Alexey Proskuryakov 2014-08-29 12:41:33 PDT
rdar://problem/16991213
Comment 1 Alexey Proskuryakov 2014-08-29 13:15:42 PDT
Created attachment 237370 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-08-29 13:16:56 PDT
Attachment 237370 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebProcessProxy.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2014-08-29 13:25:15 PDT
Comment on attachment 237370 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237370&action=review

> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:54
> +static HashSet<VisitedLinkProvider*>& allVisitedLinkProviders()
> +{
> +    ASSERT(RunLoop::isMain());
> +    static NeverDestroyed<HashSet<VisitedLinkProvider*>> providers;
> +    return providers;

I don't think these should be globals.  Instead, the WebProcessProxy should store this.
Comment 4 Alexey Proskuryakov 2014-08-29 14:30:26 PDT
Created attachment 237378 [details]
proposed fix

Makes sense.
Comment 5 Alexey Proskuryakov 2014-08-29 14:41:31 PDT
Committed <http://trac.webkit.org/changeset/173121>.