Bug 136382

Summary: Remove Node::toInputElement() in favor of is/toHTMLInputElement().
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: annevk, buildbot, darin, kling, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion none

Description Andreas Kling 2014-08-29 12:27:08 PDT
We should use the generated node conversion helpers instead of having a virtual toInputElement().
Comment 1 Andreas Kling 2014-08-29 14:16:34 PDT
Created attachment 237376 [details]
Patch
Comment 2 Build Bot 2014-08-29 16:12:20 PDT
Comment on attachment 237376 [details]
Patch

Attachment 237376 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5216322984083456

New failing tests:
fast/files/read-file-async.html
fast/files/workers/worker-read-blob-sync.html
fast/files/file-reader-directory-crash.html
http/tests/local/blob/send-hybrid-blob.html
fast/files/workers/worker-read-file-async.html
fast/files/apply-blob-url-to-xhr.html
fast/files/file-list-test.html
fast/forms/file/input-file-re-render.html
fast/files/file-reader-abort.html
fast/files/null-origin-string.html
fast/files/workers/worker-read-file-sync.html
fast/files/workers/worker-apply-blob-url-to-xhr.html
accessibility/file-upload-button-stringvalue.html
fast/workers/worker-copy-shared-blob-url.html
fast/forms/range/range-type-change-oninput.html
fast/forms/range/range-type-change-onchange-2.html
fast/files/read-blob-async.html
fast/forms/file/get-file-upload.html
fast/files/workers/worker-read-blob-async.html
Comment 3 Build Bot 2014-08-29 16:12:22 PDT
Created attachment 237386 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Darin Adler 2014-09-04 01:19:46 PDT
I believe toInputElement is a leftover from our long ago deleted WML support!
Comment 5 Anne van Kesteren 2023-05-12 23:46:47 PDT
% git grep toInputElement Source 
Source/WebCore/WebCore.order:__ZN7WebCore4Node14toInputElementEv
Source/WebCore/WebCore.order:__ZN7WebCore16HTMLInputElement14toInputElementEv