Bug 136381

Summary: LegacyProfiler: ProfileNodes should be used more like structs
Product: WebKit Reporter: Brian Burg <burg>
Component: WebCore JavaScriptAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 136380    
Bug Blocks: 136352    
Attachments:
Description Flags
Patch
none
Fix test failures timothy: review+

Brian Burg
Reported 2014-08-29 12:14:57 PDT
They do too much stuff now that the ProfileGenerator should be doing instead.
Attachments
Patch (20.24 KB, patch)
2014-09-01 18:10 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
Fix test failures (21.16 KB, patch)
2014-09-01 20:29 PDT, Brian Burg 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2014-09-01 18:10:19 PDT
Created attachment 237471 [details] Patch
Brian Burg
Comment 2 2014-09-01 18:12:20 PDT
This won't compile unless on top of 136380's changes. I am fine with combining the two patches, but it would be an even bigger pain to review.
Brian Burg
Comment 3 2014-09-01 20:29:18 PDT
Created attachment 237474 [details] Fix test failures
Brian Burg
Comment 4 2014-09-04 10:00:31 PDT
Committed r173262: <http://trac.webkit.org/changeset/173262>
Note You need to log in before you can comment on or make changes to this bug.