Bug 136378

Summary: WebPageProxy::close() is a no-op for terminated processes
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2014-08-29 11:45:41 PDT
WebPageProxy::close() has some clean-up that should happen regardless of whether the page has a running process, but it is a no-op when isValid() returns false.
Attachments
proposed fix (3.82 KB, patch)
2014-08-29 11:53 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-08-29 11:46:25 PDT
Related to <rdar://problem/16991213> and to <rdar://problem/17095600>.
Alexey Proskuryakov
Comment 2 2014-08-29 11:53:00 PDT
Created attachment 237366 [details] proposed fix
Brady Eidson
Comment 3 2014-08-29 13:22:48 PDT
Comment on attachment 237366 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=237366&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:555 > + m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID); KEY!!!!
WebKit Commit Bot
Comment 4 2014-08-29 14:23:38 PDT
Comment on attachment 237366 [details] proposed fix Clearing flags on attachment: 237366 Committed r173118: <http://trac.webkit.org/changeset/173118>
WebKit Commit Bot
Comment 5 2014-08-29 14:23:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.