Summary: | Web Inspector: Fixes to layout test infrastructure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Matt Baker
2014-08-28 18:53:25 PDT
TestExpectations already had a bug covering skipping all inspector tests: > webkit.org/b/129642 inspector [ Skip ] <https://webkit.org/b/129642> StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test) Created attachment 237531 [details]
Patch
Assertions still occur outside of inspector/replay, so for now we'll continue to skip all inspector tests. This issue is intended to address a couple unrelated bugs which were discovered while investigating https://bugs.webkit.org/show_bug.cgi?id=129642. Comment on attachment 237531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237531&action=review r=me, update the ChangeLog with the new bug title before landing. > LayoutTests/ChangeLog:9 > + Updated expected results to reflect changes to breakpoint resolution in > + issue: https://bugs.webkit.org/show_bug.cgi?id=135396. Instead of referencing the bug, you should reference the r####. Created attachment 237534 [details]
Patch
Comment on attachment 237534 [details]
Patch
r=me
Comment on attachment 237534 [details] Patch Clearing flags on attachment: 237534 Committed r173405: <http://trac.webkit.org/changeset/173405> All reviewed patches have been landed. Closing bug. |