Bug 136360

Summary: Web Inspector: Fixes to layout test infrastructure
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Matt Baker 2014-08-28 18:53:25 PDT
We currently skip ALL inspector layout tests, to avoid assertions which occur during a handful of tests (https://bugs.webkit.org/show_bug.cgi?id=129642). Recommend skipping only tests in inspector/replay.
Comment 1 Radar WebKit Bug Importer 2014-08-28 18:53:33 PDT
<rdar://problem/18170451>
Comment 2 Joseph Pecoraro 2014-08-29 11:25:00 PDT
TestExpectations already had a bug covering skipping all inspector tests:

> webkit.org/b/129642 inspector [ Skip ]

<https://webkit.org/b/129642> StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
Comment 3 Matt Baker 2014-09-02 16:35:29 PDT
Created attachment 237531 [details]
Patch
Comment 4 Matt Baker 2014-09-02 16:50:54 PDT
Assertions still occur outside of inspector/replay, so for now we'll continue to skip all inspector tests. This issue is intended to address a couple unrelated bugs which were discovered while investigating https://bugs.webkit.org/show_bug.cgi?id=129642.
Comment 5 Joseph Pecoraro 2014-09-02 16:53:11 PDT
Comment on attachment 237531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237531&action=review

r=me, update the ChangeLog with the new bug title before landing.

> LayoutTests/ChangeLog:9
> +        Updated expected results to reflect changes to breakpoint resolution in
> +        issue: https://bugs.webkit.org/show_bug.cgi?id=135396.

Instead of referencing the bug, you should reference the r####.
Comment 6 Matt Baker 2014-09-02 17:15:30 PDT
Created attachment 237534 [details]
Patch
Comment 7 Joseph Pecoraro 2014-09-02 17:16:45 PDT
Comment on attachment 237534 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2014-09-08 16:59:16 PDT
Comment on attachment 237534 [details]
Patch

Clearing flags on attachment: 237534

Committed r173405: <http://trac.webkit.org/changeset/173405>
Comment 9 WebKit Commit Bot 2014-09-08 16:59:19 PDT
All reviewed patches have been landed.  Closing bug.