Summary: | Occasional thread-safety-related crashes on the ServicesController queue | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, commit-queue, enrica, mitz, mrowe, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2014-08-28 16:44:31 PDT
Created attachment 237330 [details]
patch
Comment on attachment 237330 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237330&action=review > Source/WebKit2/UIProcess/mac/ServicesController.mm:109 > + NSSharingServiceMask serviceMask = NSSharingServiceMaskViewer | NSSharingServiceMaskEditor; I don’t see why this variable is needed. > Source/WebKit2/UIProcess/mac/ServicesController.mm:110 > + return [[NSSharingService sharingServicesForItems:items mask:serviceMask] count]; You can use .count notation here! Created attachment 237331 [details]
patch
Comment on attachment 237331 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=237331&action=review > Source/WebKit2/UIProcess/mac/ServicesController.mm:115 > + NSSharingServiceMask serviceMask = NSSharingServiceMaskViewer | NSSharingServiceMaskEditor; :-| Attachment 237331 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/mac/ServicesController.mm:52: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|