Summary: | DFG should have a reusable SSA builder | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||||||||||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
Severity: | Normal | CC: | barraclough, benjamin, cmarcelo, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, rakuco, ryuan.choi, sam, sergio | ||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||||||
Bug Depends on: | 93361, 136520 | ||||||||||||||||||||||||||
Bug Blocks: | 136610, 136639, 136641, 136330 | ||||||||||||||||||||||||||
Attachments: |
|
Description
Filip Pizlo
2014-08-27 21:35:49 PDT
Created attachment 237543 [details]
it's a start
Created attachment 237595 [details]
more
Comment on attachment 237595 [details] more Obsoleted by https://bugs.webkit.org/attachment.cgi?id=237606&action=review Created attachment 237725 [details]
it begins
Created attachment 237741 [details]
more
Created attachment 237743 [details]
pretty close
Created attachment 237750 [details]
it is written!
Created attachment 237754 [details]
it compiles!
It instacrashes though. I'll try to fix that.
Created attachment 237755 [details]
it ran something without crashing!
It can now SSA convert marsaglia.
Created attachment 237799 [details]
it can run bigger programs
Created attachment 237802 [details]
the patch
I'm still going to do some perf tests for sanity but I don't expect to see any difference since these changes are engineered to not be observable.
Attachment 237802 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGSSACalculator.h:250: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 237804 [details]
the patch
Fix style, add more comments.
Landed in http://trac.webkit.org/changeset/173413 |