Bug 136331

Summary: DFG should have a reusable SSA builder
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, rakuco, ryuan.choi, sam, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 93361, 136520    
Bug Blocks: 136610, 136639, 136641, 136330    
Attachments:
Description Flags
it's a start
none
more
none
it begins
none
more
none
pretty close
none
it is written!
none
it compiles!
none
it ran something without crashing!
none
it can run bigger programs
none
the patch
none
the patch oliver: review+

Description Filip Pizlo 2014-08-27 21:35:49 PDT 
...
Comment 1 Filip Pizlo 2014-09-02 19:55:14 PDT 
Created attachment 237543 [details]
it's a start
Comment 2 Filip Pizlo 2014-09-03 15:56:24 PDT 
Created attachment 237595 [details]
more
Comment 3 Filip Pizlo 2014-09-03 19:44:00 PDT 
Comment on attachment 237595 [details]
more

Obsoleted by https://bugs.webkit.org/attachment.cgi?id=237606&action=review
Comment 4 Filip Pizlo 2014-09-05 17:10:17 PDT 
Created attachment 237725 [details]
it begins
Comment 5 Filip Pizlo 2014-09-06 12:10:58 PDT 
Created attachment 237741 [details]
more
Comment 6 Filip Pizlo 2014-09-06 13:59:43 PDT 
Created attachment 237743 [details]
pretty close
Comment 7 Filip Pizlo 2014-09-06 20:19:38 PDT 
Created attachment 237750 [details]
it is written!
Comment 8 Filip Pizlo 2014-09-07 09:43:09 PDT 
Created attachment 237754 [details]
it compiles!

It instacrashes though.  I'll try to fix that.
Comment 9 Filip Pizlo 2014-09-07 10:33:07 PDT 
Created attachment 237755 [details]
it ran something without crashing!

It can now SSA convert marsaglia.
Comment 10 Filip Pizlo 2014-09-08 11:32:50 PDT 
Created attachment 237799 [details]
it can run bigger programs
Comment 11 Filip Pizlo 2014-09-08 12:26:29 PDT 
Created attachment 237802 [details]
the patch

I'm still going to do some perf tests for sanity but I don't expect to see any difference since these changes are engineered to not be observable.
Comment 12 WebKit Commit Bot 2014-09-08 12:27:53 PDT 
Attachment 237802 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGSSACalculator.h:250:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Filip Pizlo 2014-09-08 12:31:51 PDT 
Created attachment 237804 [details]
the patch

Fix style, add more comments.
Comment 14 Filip Pizlo 2014-09-08 17:35:51 PDT 
Landed in http://trac.webkit.org/changeset/173413