Bug 136324 – [EFL] Drop evas object cursor support

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

Although ewebkit is available on X,
ewebkit supports two types of cursor, ecore_x cursor and evas_object cursor(theme cursor).

However, evas object cursor has some issues.
1. It is just on the webview application so it can not be drawn when other application covered webview application.
2. When mouse is moved in and out of webview, cursor may be drawn twice sometimes.(x cursor and evas object cursor)

So, I suggest to drop evas object cursor from now.
If we can start to support other backend like wayland, we can also use ecore-wayland APIs for the cursor at that time.

[Ryuan Choi]

Created attachment 237273 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 237273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237273&action=review

> Source/WebCore/platform/efl/EflScreenUtilities.cpp:111
> +void applyCursorFromString(Ecore_X_Window window, const char* cursorString)

This function is to get cursor from ecore_x, isn't it ? If so, how about using applyCursorFromEcoreX() ?

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:437
>      if (cursor.image()) {

Current cursor.image() is called twice within this block. To reduce function call overhead, how about using below routine ?

if (Image* cursorImage = cursor.image()) {
    // Custom cursor.
    if (cursorImage == m_cursorIdentifier.image)
        return;

    IntPoint hotSpot;
    cursorImage->getHotSpot(hotSpot);

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:456
>          m_useCustomCursor = true;

Should we continue to keep this flag ? It looks we don't need to use this flag anymore if this patch is landed.

> Source/WebKit2/UIProcess/API/efl/EwkView.h:276
> +    WKEinaSharedString m_applicationNameForUserAgent;

Any reason you move these variable to upper place ?

[Ryuan Choi]

Created attachment 237450 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 237450 [details]
Patch

r=me.

[Ryuan Choi]

Comment on attachment 237450 [details]
Patch

Clearing flags on attachment: 237450

Committed r173354: <http://trac.webkit.org/changeset/173354>

[Ryuan Choi]

All reviewed patches have been landed.  Closing bug.