Summary: | Web Replay: only generate EncodingTraits for enums defined in the target framework | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
Component: | WebCore Misc. | Assignee: | Brian Burg <burg> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | commit-queue, joepeck, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Brian Burg
2014-08-27 14:23:45 PDT
Created attachment 244639 [details]
WIP
Created attachment 244668 [details]
Proposed Fix
This patch modifies the WEB_REPLAY inputs generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-input-generator-tests --reset-results`) Attachment 244668 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/replay/scripts/CodeGeneratorReplayInputs.py:785: whitespace before '}' [pep8/E202] [5]
ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h:60: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h:81: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h:71: The parameter name "phase" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 4 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Will fix these in one patch, since enums and inputs require similar filtering. *** This bug has been marked as a duplicate of bug 136312 *** |