Bug 136309

Summary: Occasional crashes in commitTransientZoom's transaction completion block
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, mitz, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
fix changelog mitz: review+

Description Tim Horton 2014-08-27 14:14:44 PDT
<rdar://problem/17215064>
Comment 1 Tim Horton 2014-08-27 14:16:58 PDT
Created attachment 237251 [details]
patch
Comment 2 WebKit Commit Bot 2014-08-27 14:18:07 PDT
Attachment 237251 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:653:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-08-27 14:28:23 PDT
Comment on attachment 237251 [details]
patch

Clearing r? because Dan pointed out some horrors.
Comment 4 Tim Horton 2014-08-27 15:29:50 PDT
Created attachment 237263 [details]
patch
Comment 5 Tim Horton 2014-08-27 15:30:36 PDT
Created attachment 237264 [details]
fix changelog
Comment 6 WebKit Commit Bot 2014-08-27 15:31:54 PDT
Attachment 237264 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:644:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Tim Horton 2014-08-27 16:01:44 PDT
http://trac.webkit.org/changeset/173029