Bug 136287

Summary: Take advantage of 3 parameters or32() calls
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: msaboff, oliver, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Take advantage of 3 parameters or32() calls msaboff: review+

Description Julien Brianceau 2014-08-27 06:24:33 PDT
For architectures like arm and mips, it's better to use the following sequence:

    or32(op1, op2, dest);

instead of:

    move(op1, dest);
    or32(op2, dest);
Comment 1 Julien Brianceau 2014-08-27 06:33:24 PDT
Created attachment 237223 [details]
Take advantage of 3 parameters or32() calls
Comment 2 Michael Saboff 2014-08-27 07:46:37 PDT
Comment on attachment 237223 [details]
Take advantage of 3 parameters or32() calls

r=me
Are you going to look at other logical / arithmetic ops?
Comment 3 Julien Brianceau 2014-08-27 09:06:56 PDT
Manually committed r173006: http://trac.webkit.org/changeset/173006
Comment 4 Julien Brianceau 2014-08-27 09:09:18 PDT
(In reply to comment #2)
> Are you going to look at other logical / arithmetic ops?

Yes, but I didn't find other cases yet.