Bug 136284 – [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Rohit]

Currently tooltip exists only for webpage contents. Add tooltip for toolbar buttons in Minibrowser.

[Rohit]

Created attachment 237216 [details]
Patch

[Rohit]

Currently tooltip is created at (0,0) location on window and displays on button when mouse has any/small movement. This happens because of the way "_elm_tooltip_show" function creates tooltip in EFL. Relevant code snippet from els_tooltip.c file in EFL:

static void
_elm_tooltip_show(Elm_Tooltip *tt)
{
   _elm_tooltip_show_timer_stop(tt);
   _elm_tooltip_hide_anim_stop(tt);

   if (tt->tooltip)
     {
        _elm_tooltip_reconfigure_job_start(tt);
        return;
     }
   if (tt->free_size)
     {
        tt->tt_win = elm_win_add(NULL, "tooltip", ELM_WIN_BASIC);
        elm_win_borderless_set(tt->tt_win, EINA_TRUE);
        elm_win_override_set(tt->tt_win, EINA_TRUE);
        tt->tt_evas = evas_object_evas_get(tt->tt_win);
        tt->tooltip = edje_object_add(tt->tt_evas);
        evas_object_move(tt->tooltip, 0, 0);
        elm_win_resize_object_add(tt->tt_win, tt->tooltip);


If anyone knows any workaround for same, please suggest

[Rohit]

Created attachment 237218 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 237218 [details]
Patch

LGTM. r=me.

[WebKit Commit Bot]

Comment on attachment 237218 [details]
Patch

Clearing flags on attachment: 237218

Committed r173503: <http://trac.webkit.org/changeset/173503>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.