Bug 136262

Summary:

Remove UNUSED_PARAM macros from ServicesOverlayController.mm

Product:

WebKit

Reporter:

Dana Burkart <dburkart>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dburkart, ddkilzer

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch to remove the two UNUSED_PARAM() macros	none
Patch to remove the two UNUSED_PARAM() macros	ddkilzer: review-
Remove one UNUSED_PARAM() call, and add two others.	none

Dana Burkart

Reported 2014-08-26 11:53:09 PDT

WebKit2 is failing ASan builds because of two UNUSED_PARAM macros for parameters which no longer exist.

Attachments
Patch to remove the two UNUSED_PARAM() macros (2.00 KB, patch) 2014-08-26 11:55 PDT, Dana Burkart	no flags	Details Formatted Diff Diff
Patch to remove the two UNUSED_PARAM() macros (2.01 KB, patch) 2014-08-26 12:06 PDT, Dana Burkart	ddkilzer: review-	Details Formatted Diff Diff
Remove one UNUSED_PARAM() call, and add two others. (1.97 KB, patch) 2014-08-26 12:15 PDT, Dana Burkart	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dana Burkart

Comment 1 2014-08-26 11:55:46 PDT

Created attachment 237163 [details] Patch to remove the two UNUSED_PARAM() macros

WebKit Commit Bot

Comment 2 2014-08-26 11:58:04 PDT

Attachment 237163 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dana Burkart

Comment 3 2014-08-26 12:06:50 PDT

Created attachment 237164 [details] Patch to remove the two UNUSED_PARAM() macros Fix style issues in ChangeLog.

David Kilzer (:ddkilzer)

Comment 4 2014-08-26 12:09:33 PDT

Comment on attachment 237163 [details] Patch to remove the two UNUSED_PARAM() macros View in context: https://bugs.webkit.org/attachment.cgi?id=237163&action=review Please post another patch with the UNUSED_PARAM() statements added, and the tab removed from the ChangeLog. Otherwise, this looks fine. :) > Source/WebKit2/ChangeLog:3 > + The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan failures. Maybe say: "causing ASan build failures." > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394 > -#else > - UNUSED_PARAM(rects); This one actually needs to add two UNUSED_PARAM() statements for new arguments added to the method at some point: UNUSED_PARAM(rects); UNUSED_PARAM(gapRects); UNUSED_PARAM(isTextOnly);

David Kilzer (:ddkilzer)

Comment 5 2014-08-26 12:10:59 PDT

Comment on attachment 237164 [details] Patch to remove the two UNUSED_PARAM() macros View in context: https://bugs.webkit.org/attachment.cgi?id=237164&action=review Please fix the UNUSED_PARAM() statements in ServicesOverlayController::selectionRectsDidChange(). Thanks! > Source/WebKit2/ChangeLog:3 > + The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan failures. Maybe say: "causing ASan build failures." > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394 > -#else > - UNUSED_PARAM(rects); This one actually needs to add two UNUSED_PARAM() statements for new arguments added to the method at some point: UNUSED_PARAM(rects); UNUSED_PARAM(gapRects); UNUSED_PARAM(isTextOnly);

Dana Burkart

Comment 6 2014-08-26 12:15:37 PDT

Created attachment 237165 [details] Remove one UNUSED_PARAM() call, and add two others. Changes to address ddkilzer's concerns.

David Kilzer (:ddkilzer)

Comment 7 2014-08-26 13:02:12 PDT

Comment on attachment 237165 [details] Remove one UNUSED_PARAM() call, and add two others. r=me

WebKit Commit Bot

Comment 8 2014-08-26 13:37:17 PDT

Comment on attachment 237165 [details] Remove one UNUSED_PARAM() call, and add two others. Clearing flags on attachment: 237165 Committed r172974: <http://trac.webkit.org/changeset/172974>

WebKit Commit Bot

Comment 9 2014-08-26 13:37:19 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.