Bug 136239

Summary: Building for native inlining broken on root build
Product: WebKit Reporter: Matthew Mirman <mmirman>
Component: JavaScriptCoreAssignee: Matthew Mirman <mmirman>
Status: RESOLVED INVALID    
Severity: Normal CC: fpizlo, ggaren, mmirman, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fixes building for native inlining.
none
Fixes building for native inlining. fpizlo: review-, fpizlo: commit-queue-

Description Matthew Mirman 2014-08-25 16:16:24 PDT 
Patch forthcoming.
Comment 1 Matthew Mirman 2014-08-26 13:23:09 PDT 
Created attachment 237170 [details]
Fixes building for native inlining.
Comment 2 Geoffrey Garen 2014-08-26 13:45:41 PDT 
Comment on attachment 237170 [details]
Fixes building for native inlining.

View in context: https://bugs.webkit.org/attachment.cgi?id=237170&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:4439
>          if (linkModules(m_ftlState.module, module, LLVMLinkerDestroySource, &outMsg)) {
> -            if (Options::verboseFTLFailure())
> +            // if (verboseCompilationEnabled())

Revert.
Comment 3 Matthew Mirman 2014-08-26 13:55:20 PDT 
Created attachment 237171 [details]
Fixes building for native inlining.

Fixed the commented out code.
Comment 4 Filip Pizlo 2014-08-27 14:11:01 PDT 
Comment on attachment 237171 [details]
Fixes building for native inlining.

I don't think we should make it convention that everything is either exported or ALWAYS_INLINE.  We should have a solution in LLVM that allows us to call static functions from the JIT.
Comment 5 Csaba Osztrogonác 2015-09-14 11:11:10 PDT 
Comment on attachment 237170 [details]
Fixes building for native inlining.

Cleared Geoffrey Garen's review+ from obsolete attachment 237170 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 6 Csaba Osztrogonác 2015-09-24 07:19:23 PDT 
There is no native inlining since https://trac.webkit.org/changeset/187555