Bug 136218

Summary: [CSS Grid Layout] Replace the usage of size_t by unsigned
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, buildbot, darin, jer.noble, kling, rego, rniwa, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 136217    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch benjamin: review+

Sergio Villar Senin
Reported 2014-08-25 03:29:18 PDT
size_t is generally used for sizes of memory objects. We're using it for indexes and spans in the grid. The fact that we're using Vectors to represent the grid should not force us to use size_t, unsigned seems to fit better in this case.
Attachments
Patch (40.61 KB, patch)
2014-11-12 10:37 PST, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (42.63 KB, patch)
2014-11-13 07:22 PST, Sergio Villar Senin 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2014-08-25 03:30:21 PDT
See for example: https://bugs.webkit.org/show_bug.cgi?id=135701#c2
Sergio Villar Senin
Comment 2 2014-11-12 10:37:45 PST
Created attachment 241434 [details] Patch
Sergio Villar Senin
Comment 3 2014-11-13 07:22:11 PST
Created attachment 241483 [details] Patch Added a missing conversion
Sergio Villar Senin
Comment 4 2014-11-18 00:48:40 PST
Would it be possible to get this reviewed?
Benjamin Poulain
Comment 5 2014-11-18 01:12:49 PST
Comment on attachment 241483 [details] Patch Looks reasonable. If someones creates a grid overflowing unsigned, she/he is crazy :)
Sergio Villar Senin
Comment 6 2014-11-18 01:33:55 PST
(In reply to comment #5) > Comment on attachment 241483 [details] > Patch > > Looks reasonable. > If someones creates a grid overflowing unsigned, she/he is crazy :) Yeah :) In any case, I have uploaded this only after landing bug 136217 that ensures that we won't overflow unsigned as it sets a hard limit to the number of tracks (1 million as recommended by specs).
Sergio Villar Senin
Comment 7 2014-11-20 01:49:12 PST
Committed r176390: <http://trac.webkit.org/changeset/176390>
Note You need to log in before you can comment on or make changes to this bug.