Summary: | [CSS Grid Layout] Replace the usage of size_t by unsigned | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||
Component: | CSS | Assignee: | Sergio Villar Senin <svillar> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, benjamin, buildbot, darin, jer.noble, kling, rego, rniwa, svillar | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 136217 | ||||||||
Bug Blocks: | 60731 | ||||||||
Attachments: |
|
Description
Sergio Villar Senin
2014-08-25 03:29:18 PDT
See for example: https://bugs.webkit.org/show_bug.cgi?id=135701#c2 Created attachment 241434 [details]
Patch
Created attachment 241483 [details]
Patch
Added a missing conversion
Would it be possible to get this reviewed? Comment on attachment 241483 [details]
Patch
Looks reasonable.
If someones creates a grid overflowing unsigned, she/he is crazy :)
(In reply to comment #5) > Comment on attachment 241483 [details] > Patch > > Looks reasonable. > If someones creates a grid overflowing unsigned, she/he is crazy :) Yeah :) In any case, I have uploaded this only after landing bug 136217 that ensures that we won't overflow unsigned as it sets a hard limit to the number of tracks (1 million as recommended by specs). Committed r176390: <http://trac.webkit.org/changeset/176390> |